Re: [Patch] Warning fixes for glib



On  4 Nov, Tim Janik wrote:

> i backed his change out already, but also nuked my initial (5 /*
> SIGTRAP */) kludge. the macro now simply reads signal(SIGTRAP) which
> should be good enough. this'll work for the cases where we already use
> G_BREAKPOINT() in debugging code in glib simply by including
> <signal.h>, and if developers of non-x86/non-alpha use this macro,
> they'll either have to include <signal.h> or send us patches for new asm statements.

I don't like it as much as simply including it but it's definitely
much better to stop compilation at that point than simply doing
"some"thing with some having a small probability of being the wrong
one.

--
Servus,
       Daniel




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]