Re: label performance patch

[Owen Taylor <otaylor redhat com>]

Tim Janik <timj gtk org> writes:

> On 14 Nov 2001, Owen Taylor wrote:
> 
> > 
> > Tim Janik <timj gtk org> writes:
> > 
> > > On Tue, 13 Nov 2001, Alex Larsson wrote:
> > > 
> > > > GtkLabel keeps reflowing wrapped labels all the time. Here is a fix:
> > > 
> > > > @@ -1346,8 +1342,8 @@ gtk_label_ensure_layout (GtkLabel *label
> > > >     *     5. gtk_misc_set_padding has changed xpad.
> > > >     *     6.  maybe others?...
> > > >     *
> > > > -   * Too much of a pain to detect all these case, so always re-fill.  I
> > > > -   * don't think it's really that slow.
> > > > +   * (un)Fortunately, PangoLayout does not currently support GTK_JUSTIFY_FILL,
> > > > +   * so this is not an issue.
> > > >     */
> > > 
> > > is this going to be fixed any time soon? i'd rather not loose GTK_JUSTIFY_FILL
> > > for 2.0 labels.
> > 
> > No, this is not going to be fixed for Pango-1.0 / GTK+-2.0. Correct
> > fill justification for international text is rather a hard problem
> > and while planned for Pango is not a high priority at this point.
> 
> uhm, it's quite poor to not have fill justification for the cases
> that worked in 1.2. while fixing this for i18n text might still require
> more time than we currently have, we should at least get it back to work
> for the western languages.

I'd consider fill justification a frill ... it makes things a little
prettier if done well, makes things a lot uglier if abused, and
doesn't really increase legibility any in any case.

I've filed it in the bug tracker as #64538 with some notes on a hack
implementation and if a spare afternoon shows up, I may look at it.

The API (pango_layout_set_justify()) is already there so you can think
of it as "it does do fill justiifcation, it just does a really bad job
of it."

Regards,
                                        Owen