PATCH: gtk_font_selection crashes



Hi,

when selected a fractional size on the applications which
uses gtk_font_selection* (), gtk_clist_select_row () is
called infinitely and it crashes. I have fixed that
problem.

the detail of this problem is:
http://bugs.debian.org/100678

Regards,
--
Akira TAGOH  : tagoh gnome gr jp  / Japan GNOME Users Group
at gclab org : tagoh gnome-db org / GNOME-DB Project
             : tagoh redhat com   / Red Hat, Inc.
             : tagoh debian org   / Debian Project
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gtk+/ChangeLog,v
retrieving revision 1.1061.2.376
diff -u -r1.1061.2.376 ChangeLog
--- ChangeLog	2001/10/16 22:14:51	1.1061.2.376
+++ ChangeLog	2001/11/17 01:21:17
@@ -1,3 +1,8 @@
+2001-11-17  Akira TAGOH <tagoh redhat com>
+
+	* gtk/gtkfontsel.c (gtk_font_selection_select_best_size):
+	Fix problem where fractional sizes caused infinite loop again.
+
 2001-10-17  Yanko Kaneti <yaneti declera com>
 
 	* configure.in (ALL_LINGUAS): Add "bg" to the language list.
Index: gtk/gtkfontsel.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkfontsel.c,v
retrieving revision 1.23.2.9
diff -u -r1.23.2.9 gtkfontsel.c
--- gtk/gtkfontsel.c	2001/04/02 03:50:58	1.23.2.9
+++ gtk/gtkfontsel.c	2001/11/17 01:21:18
@@ -1609,9 +1609,11 @@
   
   if (found)
     {
-      fontsel->size = best_size;
-      gtk_clist_moveto(GTK_CLIST(fontsel->size_clist), best_row, -1, 0.5, 0);
-      gtk_clist_select_row(GTK_CLIST(fontsel->size_clist), best_row, 0);
+		if (best_size != fontsel->selected_size) {
+			fontsel->size = best_size;
+			gtk_clist_moveto(GTK_CLIST(fontsel->size_clist), best_row, -1, 0.5, 0);
+			gtk_clist_select_row(GTK_CLIST(fontsel->size_clist), best_row, 0);
+		}
     }
   else
     {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]