Re: cross platform xinerama API proposal

[Erwann Chenede <Erwann Chenede Sun COM>]

Hi Matthias,

>From: "Matthias Clasen" <matthiasc poet de>
>
>Looks very similar to what I added for my Xinerama-aware menus patch
>(http://bugzilla.gnome.org/show_bug.cgi?id=56104),
>so it should be sufficient for the functionality provided by that patch.

Yes, it very similar, the main differences are :
- the xinerama functions are logically attached to the GdkDisplay 
  instead of GdkScreen.
- the functions naming is different.
- 2 additional functions at_window and use_virtual_screen.

I'll incorporate your fix for the menu and window placement at the 
same time, if it is ok with you.

>
>The only thing I would do differently is avoiding the special-case for
>non-Xinerama mode. Why not just have gdk_display_get_num_monitors and
>gdk_display_get_monitor_geometry return 1 and the screen geometry,
>respectively ? 

Yes, this makes sense.

>Seems more natural to me and would render
>gdk_display_use_virtual_screen superfluous
>(since you can just test for num_monitors == 1).

gdk_display_use_virtual_screen is just a convenience function,
I find more "natural" to have a test function instead of having 
to use gdk_display_get_num_monitors to check if the GdkDisplay 
is using xinerama like mode.

Thanks,

Erwann

[ I speak for myself, not for my employer. ]
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
  Erwann Chénedé, Sun Microsystems Ireland
  Desktop Applications & Middleware Group
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=