Re: #59803: patch

[Owen Taylor <otaylor redhat com>]

Kristian Rietveld <kristian planet nl> writes:

> On 2 Oct 2001, Owen Taylor wrote:
> >
> > GtkOldEditable is almost exactly identical in its handling of these
> > signals to the way GtkEntry was prior to your patch. It thus basically
> > needs exactly the same fix as GtkEditable.
> >
> > Maybe the confusion is in what GtkOldEditable is.
> >
> > GtkEditable used to be a class you could derive from. When GtkEditable
> > was converted into an interface, GtkOldEditable was added which
> > is a class you can derive from and that implements the GtkEditable
> > interface.
> >
> > This is used for legacy widgets like GtkText where we don't want
> > to go through the bother of making them support the GtkEditable
> > interface directly.
> 
> Okay, do you mean something like this: ?
> 
> Index: gtkoldeditable.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gtk/gtkoldeditable.c,v
> retrieving revision 1.7
> diff -u -r1.7 gtkoldeditable.c
> --- gtkoldeditable.c    2001/07/20 18:05:32     1.7
> +++ gtkoldeditable.c    2001/10/02 19:10:29
> @@ -361,8 +361,8 @@
>  static void
>  gtk_old_editable_editable_init (GtkEditableClass *iface)
>  {
> -  iface->insert_text = gtk_old_editable_insert_text;
> -  iface->delete_text = gtk_old_editable_delete_text;
> +  iface->do_insert_text = gtk_old_editable_insert_text;
> +  iface->do_delete_text = gtk_old_editable_delete_text;
>    iface->get_chars = gtk_old_editable_get_chars;
>    iface->set_selection_bounds = gtk_old_editable_set_selection_bounds;
>    iface->get_selection_bounds = gtk_old_editable_get_selection_bounds;

No. I mean a change to remove the insert_text/delete_text/changed
signals for GtkOldEditable, and the miscellaneous changes related
to that.

Regards,
                                        Owen