Re: [PATCH] make make dist work without making first



Hi,

Raja R Harinath <harinath cs umn edu> writes:
> jacob berkman <jacob ximian com> writes:
>> this patch was required for me to be able to make dist without distcheck
>> or building initially.
> [snip]
>> --- gobject/Makefile.am	2001/09/25 06:03:22	1.40
>> +++ gobject/Makefile.am	2001/10/01 22:28:54
>> @@ -14,6 +14,9 @@
>> 
>>  libglib = $(top_builddir)/glib/libglib-1.3.la
>> 
>> +$(libglib):
>> +	$(MAKE) -C $(top_builddir)/glib
> 
> Sorry for being dense, but why is this necessary?  
> 
> The toplevel Makefile lists 'glib' before 'gobject' -- so $(libglib)
> must have already been built and up-to-date by the time this Makefile
> is invoked.

Sorry, I didn't read the subject line.  

However, it appears that the reason you want to build $(libglib) is
that you want to distribute the built sources.  It's not necessary to
distribute those files which are generated using C code (i.e. using
glib-genmarshal.*).  It is only necessary to distribute stuff built
with Perl.  

Wouldn't that be a better way to solve the problem rather than
building $(libglib)?  Of course, this'll require the use of
BUILT_SOURCES with a sane released 'automake' (say v1.5). 

  BUILT_SOURCES = $(perl_built_files) $(c_built_files)
  dist-hook-local: $(perl_built_sources)
  
- Hari
-- 
Raja R Harinath ------------------------------ harinath cs umn edu
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]