Re: horrible things

[jacob berkman <jacob ximian com>]

On Wed, 2001-10-03 at 15:48, Owen Taylor wrote:
> 
> jacob berkman <jacob ximian com> writes:
> 
> > this patch allows the gtk docs to build w/o an X connection.
> 
> I'm not taking this patch. We'll need clean solutions of this
> sort of or GTK+-2.2, so I wouldn't object to clean patches,
> but I'm not going to put in bad hacks.

we're in agreement here - i was mostly asking for some direction to a
better solution.

> (I think there should be a fix for at least gtkcolorsel.c on
> Erwann's gtk-multihead branch.)

yep, looking at implementing it this way.  thanks.

> > Index: gdk/x11/gdkevents-x11.c
> > ===================================================================
> > RCS file: /cvs/gnome/gtk+/gdk/x11/gdkevents-x11.c,v
> > retrieving revision 1.62
> > diff -u -r1.62 gdkevents-x11.c
> > --- gdk/x11/gdkevents-x11.c	2001/10/03 18:19:47	1.62
> > +++ gdk/x11/gdkevents-x11.c	2001/10/03 19:31:54
> > @@ -2136,6 +2136,9 @@
> >    gint i;
> >    GValue tmp_val = { 0, };
> >  
> > +  if (!xsettings_client)
> > +    return FALSE;
> > +
> >    for (i = 0; i < G_N_ELEMENTS (settings_map) ; i++)
> >      if (strcmp (settings_map[i].gdk_name, name) == 0)
> >        {

do you really hate this part too?

jacob
--