Re: [PATCH] GtkInputDialog signal parameter types

[Owen Taylor <otaylor redhat com>]

Tim Janik <timj gtk org> writes:

> On 15 Oct 2001, Murray Cumming wrote:
> 
> > Here's a simple patch that creates the enable-device and enable-device signals
> > with correct parameter types. I assume that the declaration of the default
> > signal handler is the correct one. 
> 
> hum, i fail to see where these signals are being emitted, and they
> don't contain the conventional function wrappers:
> 
> void gtk_input_dialog_enable_device  (GtkInputDialog    *inputd,
>                                       GdkDevice         *device);
> void gtk_input_dialog_disable_device (GtkInputDialog    *inputd,
>                                       GdkDevice         *device);
> 
> but aren't action signals either.
> so i wonder whether:
> - these signals are used anywhere in user code directly
>   (in which case the above wrappers should be added and
>   direct emission should be deprecated)
> - these signals should simply be removed as they don't seem
>   to be used.
> 
> owen, can you comment on this?

Read closer:

====
      if (gdk_device_set_mode (inputd->current_device, mode))
	{
	  if (mode == GDK_MODE_DISABLED)
	    gtk_signal_emit (GTK_OBJECT (inputd),
			     input_dialog_signals[DISABLE_DEVICE],
			     info);
	  else
	    gtk_signal_emit (GTK_OBJECT (inputd),
			     input_dialog_signals[ENABLE_DEVICE],
			     info);
	}
===

They _are_ emitted from within the widget and cannot be emitted
from user code.

Regards,
                                        Owen