Re: static correctness



On Sat, 27 Oct 2001, Hans Breuer wrote:

> At 20:11 26.10.01 +0200, Tim Janik wrote:
> >On Fri, 26 Oct 2001, Hans Breuer wrote:
> >
> >> [...]
> >> Would a patch to correct this be accepted and if so
> >> be required for review? (It would be quite large and overly
> >> simple.)
> >
> >fixing static-ness will definitely be accepted.
> >postiong the patch here when asking for aproval won't hurt
> >though and might speed up matters.
> >
> You asked for it, here it comes:
> Static-Ness part one - Gtk

well, it would have been easier to review those 18 static-ness
changes without the cosmetic interveience (which is ok byitself
as well)... ;)

please commit.

> 	Hans
> 
> 
> 	* gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c
> 	  gtk/gtkimmulticontext.c gtk/gtklabel.c gtk/gtkliststore.c
> 	  gtk/gtkmenu.c gtk/gtkpaned.c gtk/gtkrc.c gtk/gtkscale.c
> 	  gtk/gtkstyle.c gtk/gtktextbuffer.c gtk/gtktextlayout.c
> 	  gtk/gtktexttag.c gtk/gtktexttagtable.c gtk/gtktextview.c
> 	  gtk/gtktreestore.c gtk/gtkvbbox.c : 
> 	to simplify parsing for exported functions:
> 	- made implementation signature static, when the local 
> 	  prototype already was
> 	- put the functions return value on it's own line
> 	- added as space between the function name and the 
> 	  opening bracket
> 

---
ciaoTJ




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]