Re: GTKRadioButton groups breakage/weirdness

[Owen Taylor <otaylor redhat com>]

Tim Janik <timj gtk org> writes:

> On 29 Oct 2001, Owen Taylor wrote:
> 
> > > jup, this is actually bad API.
> > 
> > Well, yes, that's been known for a long time, which is why
> > gtk_radio_button_new_from_widget() was added.
> > 
> > > i guess i'd accept a patch that changed radio button groups from GSList
> > > into GList (and walked group->prev in gtk_radio_button_new_with_label), as
> > > 1) walking a GList* cast into a GSList* and just accessing ->data will work
> > >    fine
> > 
> > I really think this is too major a change to make at this point, even
> > if it would have been desirable a few months ago. A spot check in LXR
> > reveals thousands of uses of gtk_radio_button_group(), virtually all of
> > which involve assignment to a variable.
> > 
> > If we were going to change it, I'd make GtkRadioButtonGroup an
> > opaque data type, or even a GObject, so you could have things
> > like "gtk_radio_button_group_get_active_widget(). 
> > 
> > But we really have to cut off major and even minor changes at this
> > point.
> 
> yep, that's right. the reason i think this is still feasible
> to make is that you can get by with a compile warning (as long
> as you go for GSList->GList, not making it opaque or objectish).

Yuck!
                                        Owen