Re: Patch for #59222, and small code cleanup

[Jonathan Blandford <jrb redhat com>]

Kristian Rietveld <kristian planet nl> writes:

> Hi,
> 
> Here's a patch that fixes #59222. It also contains some small code
> cleanups of the treeview search code. Details are in ChangeLog.

Doesn't apply.  You seem to have half added user_data to the search
func, and not added the destroy -- check out current CVS.  Secondly, you
seem to be getting the path every time, and then looking up the tree.
This is pretty inefficient.  I think I would walk the RBTree and keep
the iter in sync internally.  This is done in a number of places.  The
easiest to copy is probably the code in gtk_tree_selection_foreach.

Thanks for looking at this, though,
-Jonathan