Re: [PATCH] various Makefile.am cleanups

[Owen Taylor <otaylor redhat com>]

Matt Wilson <msw gimp org> writes:

> Most of these are minor except perhaps the gdk-pixbuf changes, so I
> thought I'd send it here first.

I assume that the adding of DEPENDENCIES here is because Makefile.am
is or was not correctly determining the dependences when the
LIBADD contained a variable like this.

I dont' like commenting it out. If we _know_ that it isn't needed
or it's causing problems, we should just remove it. Otherwise
we should leave it in.

If we make a mistake, there is always CVS.

Other than that, the patch looks fine.

Regards,
                                        Owen

Index: gdk-pixbuf/ChangeLog
===================================================================
RCS file: /cvs/gnome/gtk+/gdk-pixbuf/ChangeLog,v
retrieving revision 1.329
diff -u -r1.329 ChangeLog
--- gdk-pixbuf/ChangeLog	2001/09/17 15:53:59	1.329
+++ gdk-pixbuf/ChangeLog	2001/09/17 16:14:57
@@ -1,3 +1,11 @@
+2001-09-17  Matt Wilson  <msw redhat com>
+
+	* Makefile.am (libpixbufloader_xbm_la_LDFLAGS): removed duplicate
+	LDFLAGS definition, use the -avoid-version one.
+	(libpixbufloader_tga_la_LDFLAGS): likewise
+	(libgdk_pixbuf_1_3_la_DEPENDENCIES): dependencies should be
+	autogenerated, should this be here?  Commented this out. 
+
 Mon Sep 17 11:49:02 2001  Owen Taylor  <otaylor redhat com>
 
 	* pixops/*: Mirror GdkInterpType to PixopsInterpType
Index: gdk-pixbuf/Makefile.am
===================================================================
RCS file: /cvs/gnome/gtk+/gdk-pixbuf/Makefile.am,v
retrieving revision 1.104
diff -u -r1.104 Makefile.am
--- gdk-pixbuf/Makefile.am	2001/09/16 23:54:37	1.104
+++ gdk-pixbuf/Makefile.am	2001/09/17 16:14:57
@@ -241,7 +239,7 @@
 @STRIP_END@
 
 libgdk_pixbuf_1_3_la_LIBADD = pixops/libpixops.la $(builtin_objs) $(GDK_PIXBUF_DEP_LIBS)
-libgdk_pixbuf_1_3_la_DEPENDENCIES = $(builtin_objs)
+#libgdk_pixbuf_1_3_la_DEPENDENCIES = $(builtin_objs)
 
 gdk_pixbuf_headers = \
 	gdk-pixbuf.h		\