Re: patch for gdk-pixbuf to read and write PNG tEXt chunks

[Sven Neumann <sven gimp org>]

Hi,

Jens Finke <jens triq net> writes:

> >  - should we prefix the options to be stored as tEXt using for
> >    example "tEXt::" and include that prefix in the data attached
> >    to the GdkPixbuf as well?
> 
> You propose to prefix the attached data to the GdkPixbuf object and
> remove this prefix before adding it as png tEXt? IMO this could be
> useful, since it allows further extensions of this system.

yes, this is what I was proposing.

> [...]
> > +
> > +       if (num_keys > 0) {
> > +               text_ptr = g_new0 (png_text, num_keys);
> > +               for (j = 0; j < num_keys; j++) {
> > +                       text_ptr[j].compression = -1;
> 
> Can you use the PNG_TEXT_COMPRESSION_NONE constant here? This makes it
> more obvious that we use no compression.

I didn't knew about that constant. If there is consensus that we want
this addition, I'll provide a new patch with this changes.


Salut, Sven