Re: Open API Bugs, 28 September

[Tor Lillqvist <tml iki fi>]

rsteinke w-link net writes:
 > Notes: Someone who understands the win32 backend needs to check that
 >        the GIOChannelError error messages which replaced the old
 >        GIOError error messages make sense.
 > 
 > Several of the errors returned (particularly in g_io_win32_msg_[read,write]())
 > were straight translations from GIOError to GIOChannelError when
 > I did the major GIOChannel patches, and are probably not correct.
 > I'm concerned that it may be necessary to add additional error
 > types to the GIOChannelError enum. If someone who knows win32
 > could look this over, I'd appreciate it.

I am looking a bit at this now. When a Win32 API call has failed, the
right thing is to call g_win32_error_message (GetLastError ()) and use
that message. BTW, should error messages in giowin32.c be marked for
translation? In giounix.c all g_set_error() us calls use strerror()
which returns a translated string. In giochannel.c (for instance),
some g_set_error() calls with stating messages have them marked,
others not.

--tml