Re: Changes to gtk_menu_popup
- From: Owen Taylor <otaylor redhat com>
- To: "Padraig O'Briain" <Padraig Obriain Sun COM>
- Cc: gtk-devel-list gnome org
- Subject: Re: Changes to gtk_menu_popup
- Date: Mon, 4 Feb 2002 12:31:20 -0500 (EST)
"Padraig O'Briain" <Padraig Obriain Sun COM> writes:
> I noticed that gtk_menu_popup() changed over the weekend.
>
> Should the following change also be made?
>
> Index: gtkmenu.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gtk/gtkmenu.c,v
> retrieving revision 1.88
> diff -u -p -r1.88 gtkmenu.c
> --- gtkmenu.c 2002/02/03 01:25:32 1.88
> +++ gtkmenu.c 2002/02/04 07:57:55
> @@ -727,6 +727,8 @@ gtk_menu_popup (GtkMenu *menu,
> if ((current_event->type != GDK_BUTTON_PRESS) &&
> (current_event->type != GDK_ENTER_NOTIFY))
> menu_shell->ignore_enter = TRUE;
> +
> + gdk_event_free (current_event);
> }
Good catch. Go ahead and commit. I've filed it as #70519 because it is
also present on the stable brach. (Quite an old memory leak.)
Regards,
Owen
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]