Re: Anti-<ctype.h> patch for Pango

[Darin Adler <darin bentspoon com>]

On 2/9/02 10:52 AM, "Owen Taylor" <otaylor redhat com> wrote:

> Looks fine, except that it it conflicts with the outstanding change
> in http://bugzilla.gnome.org/show_bug.cgi?id=69907. If you want to
> handle them both, and then file a bug about GMarkup's handling of
> space (the other discussed in 69907), that would be great :-)

I think my original Pango patch correctly deals with the XML definition of
whitespace (by accident, I must admit). And here's a glib patch that does
the same for GMarkup. OK to commit both?

Index: glib/gmarkup.c
===================================================================
RCS file: /cvs/gnome/glib/glib/gmarkup.c,v
retrieving revision 1.15
diff -p -u -r1.15 gmarkup.c
--- glib/gmarkup.c    2002/01/30 22:14:16    1.15
+++ glib/gmarkup.c    2002/02/09 22:34:00
@@ -28,7 +28,7 @@
 #include "glibintl.h"
 
 GQuark
-g_markup_error_quark ()
+g_markup_error_quark (void)
 {
   static GQuark error_quark = 0;
 
@@ -628,7 +628,7 @@ skip_spaces (GMarkupParseContext *contex
 {
   do
     {
-      if (!g_unichar_isspace (g_utf8_get_char (context->iter)))
+      if (!g_ascii_isspace (*context->iter))
         return;
     }
   while (advance_char (context));

===================================================================

    -- Darin