Re: [patch] scrolling fix for GtkTreeView

[Jonathan Blandford <jrb redhat com>]

Darin Adler <darin bentspoon com> writes:

Hi Darin,

One line of your patch looks right, and looks wrong.

> @@ -3865,7 +3865,8 @@ validate_visible_area (GtkTreeView *tree
>        gtk_tree_row_reference_free (tree_view->priv->top_row);
>        tree_view->priv->top_row =
>      gtk_tree_row_reference_new_proxy (G_OBJECT (tree_view),
> tree_view->priv->model, above_path);
> -      tree_view->priv->top_row_dy = - area_above;
> +      tree_view->priv->top_row_dy = MAX (GTK_RBNODE_GET_HEIGHT (node),
> tree_view->priv->expander_size) + area_above;

top_row_dy is how far from the top of top_row the visible area starts.
area_above is the amount left over while walking up the tree.  I think
we want to change it to, as I don't think I properly handle the case
where I run out of nodes.

if (area_above < 0)
  tree_view->priv->top_row_dy = - area_above;
else
  tree_view->priv->top_row_dy = 0;

The next line:
> +      need_redraw = TRUE;
seems right.

Thanks,
-Jonathan