Re: patch to remove --disable-nls option from glib-gettext.m4



Sven Neumann <sven gimp org> writes:

> Hi,
> 
> Owen Taylor <otaylor redhat com> writes:
> 
> > > here's a patch that removes the possibility to disable NLS from
> > > glib-gettext.m4 (and acinclude.m4). Disabling NLS is not 
> > > supported and the configure option --disable-nls will only
> > > confuse people. The patch is rather lengthy since I had to 
> > > adjust indentations all over the place. Basically it changes
> > > only a few lines at the top.
> > 
> > Can you regen the diff with 'cvs diff -wu' ?
> 
> sure.

Thanks. The patch looks fine, but:
 
> Index: m4macros/glib-gettext.m4
> ===================================================================
> RCS file: /cvs/gnome/glib/m4macros/glib-gettext.m4,v
> retrieving revision 1.3
> diff -u -p -w -u -r1.3 glib-gettext.m4
> --- m4macros/glib-gettext.m4	2001/09/18 22:28:32	1.3
> +++ m4macros/glib-gettext.m4	2002/01/16 16:43:06
> @@ -14,24 +14,17 @@
>  # If you make changes to this file, you MUST update the copy in
>  # acinclude.m4. [ aclocal dies on duplicate macros, so if
>  # we run 'aclocal -I macros/' then we'll run into problems
> -# once we've installed glib-gettext.m4 :-( ]
> +# once we've installed glib-gettext.m4 ]

That was my unhappiness, not yours, you can't remove it! ;-)

Regards,
                                        Owen



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]