Re: gtk-demo's patch
- From: Jonathan Blandford <jrb redhat com>
- To: German Poo Caaman~o <gpoo ubiobio cl>
- Cc: Owen Taylor <otaylor redhat com>, gtk-devel-list gnome org, kristian planet nl
- Subject: Re: gtk-demo's patch
- Date: 18 Jan 2002 12:39:27 -0500
German Poo Caaman~o <gpoo ubiobio cl> writes:
> El lun, 14-01-2002 a las 16:22, Owen Taylor escribió:
> > German Poo Caaman~o <gpoo ubiobio cl> writes:
> >
> > > I was following the editable_cells.c code of gtk-demo to implement
> > > a GtkTreeView editable. After fight a little, I was discover a
> > > little bug on definition of old_text variable. However, it doesn't
> > > have a useful in the program, but confuse.
> > >
> > > May I commit?
> >
> > This chnage looks right. But old_text will need to be freed afterwords
> > as well.
>
> Ok. This patch free the memory when the column is G_TYPE_STRING.
> Nothing happens if the column is G_TYPE_INT.
Now that I look at the darn function closely, I see that old_text is
never even used! This whole demo (along with the other demos) could
use a cleanup.
Thanks,
-Jonathan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]