Re: Range patchlet

[Owen Taylor <otaylor redhat com>]

Tim Janik <timj gtk org> writes:

> On Thu, 24 Jan 2002, Bill Haneman wrote:
> 
> > Hi:
> > 
> > Here is a two-line patch that fixes a small bug in the gtkrange focus
> > drawing - note that without this patch, the focus indication is only
> > visible on the left and top edges, and is clipped out of the right and
> > bottom edges.  With this patch the focus indication is contained
> > correctly inside the slider rectangle.
> > 
> > OK to commit ?
> 
> yep thanks, this is the standard off-by-one error with width/height.

Actually, when support for wide focus indicators was added, we changed the
interpretation of the rectangle passed to paint_focus; from Changes-2.0:

     The rectangle passed in is the bounding box, instead of
     the rectangle used in the <function>gdk_draw_rectangle()</function> call, 
     so it is no longer necessary to subtract 1 from the width and height.

Regards,
                                        Owen