Re: bugs for GTK+-2.0.6 release

[Owen Taylor <otaylor redhat com>]

Choe Hwanjin <krisna kldp org> writes:

> On Wed, Jul 24, 2002 at 05:43:39PM -0400, Owen Taylor wrote:
> > 
> > I'm planning to start work on a GTK+-2.0.6 release tomorrow.
> > My current plan is to release *exactly* what is in CVS now:
> > I think we need a new release to fix bug #85976
> > (menu keynav problems with insensitive menu items), and to
> > get out some tree view fixes that Kris and Jonathan have
> > done; but I don't really have time to go through bugzilla.
> > 
> > I'd like to ask people if they know of any other bugs that are:
> > 
> >  - Urgent (crashes, bad misbehavior)
> >  - Tracked down to something specific
> >  - We have a patch, or it should be easy to make a patch.
> 
> I think bug #88824 should be fixed. I don't know it is 
> about Pango or Gtk. But aborting a whole process is not
> what people want.
> http://bugzilla.gnome.org/show_bug.cgi?id=88824

Well, it wasn't really what I was looking for --- I was more
interested in places where there was a patch already. But
looking at it for a minute or two, it turned out to be something
pretty simple. Like many assertion failures, it was a bug in 
the assertion.

I've fixed it in CVS now.

Regards,
                                        Owen

iff -u -p -r1.90 pango-layout.c
--- pango/pango-layout.c        1 Mar 2002 17:15:18 -0000       1.90
+++ pango/pango-layout.c        25 Jul 2002 03:09:29 -0000
@@ -2898,7 +2898,7 @@ pango_layout_check_lines (PangoLayout *l

       g_assert (end <= (layout->text + layout->length));
       g_assert (start <= (layout->text + layout->length));
-      g_assert (delim_len < 3);
+      g_assert (delim_len < 4);        /* PS is 3 bytes */
       g_assert (delim_len >= 0);

       state.items = pango_itemize (layout->context,