RE: bugs for GTK+-2.0.6 release

["Shivram U" <shivaram upadhyayula wipro com>]

Hi Owen,

> >    http://bugzilla.gnome.org/show_bug.cgi?id=75597 There is a patch
> > available. If it requires any modifications, i'll make them.
> 
> I think this is most suitable for only going in HEAD since it just
> adds warnings for application errors and doesn't actually fix any bugs
> in GTK+.
> 
> Go ahead and commit to GTK+ HEAD, though I'd suggest, as an
> editorial suggestion:

I have modified the patch as per your comments and committed to GTK+ HEAD.

Best Regards,
Shivram U

> 
> +  if (image->depth != v->depth)
> +    {
> +      g_warning ("%s: Depth of the Source image is %d where as "
> +                 "the visual depth of the colormap passed is %d",
> +                 G_STRLOC, image->depth, v->depth);
> +      return;
> +    } 
> 
> Would be better as
> 
> +      g_warning ("%s: The depth of the source image (%d) doesn't"
> +                 "match the depth of the colormap passed in (%d)."),
> +                 G_STRLOC, image->depth, v->depth);
> 
> Regards,
>                                         Owen
>