Re: [patch] gdk-pixbuf loaders crash on CMYK JPEGs
- From: Owen Taylor <otaylor redhat com>
- To: Michael Natterer <mitch gimp org>
- Cc: gtk-devel-list gnome org, maclas gmx de
- Subject: Re: [patch] gdk-pixbuf loaders crash on CMYK JPEGs
- Date: Mon, 29 Jul 2002 15:16:38 -0400 (EDT)
Michael Natterer <mitch gimp org> writes:
> Hi all,
>
> currently io-jpeg.c simply crashes on CMYK JPEGs (or any JPEG with
> n_components != 1 or 3). The attached patch does the following:
>
> - removes GREY->RGB conversion routine
> - uses the libjpeg built-in ability to promote everything to either
> RGB or CMYK
> - adds CMYK->RGB conversion.
> - refuses to load files with unknown colorspace.
>
> I guess it should be comitted to both branches.
>
> OK to commit or is it too much of a change and should go to
> Bugzilla first?
Please see:
http://bugzilla.gnome.org/show_bug.cgi?id=61211
If we need to make a fix in stable, I'd much rather either use:
- The smallest possible fix (just error on unknown colorspaces)
Or:
- The code we are already using in HEAD
Regards,
Owen
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]