Pango uninitialized value

[Alex Larsson <alexl redhat com>]

I get lots of warnings from valgrind about uninitialized value in 
pango-layout.c::next_cluster_start() when reading 
gs->glyphs[i].attr.is_cluster_start. 

I can't for the life of me find where attr is supposed to be cleared.

I think something like this is needed:

Index: modules/basic/basic-x.c
===================================================================
RCS file: /cvs/gnome/pango/modules/basic/basic-x.c,v
retrieving revision 1.29
diff -u -p -r1.29 basic-x.c
--- modules/basic/basic-x.c     20 Mar 2002 20:07:27 -0000      1.29
+++ modules/basic/basic-x.c     23 Mar 2002 04:56:03 -0000
@@ -312,6 +312,8 @@ set_glyph (PangoFont *font, PangoGlyphSt
   glyphs->glyphs[i].geometry.x_offset = 0;
   glyphs->glyphs[i].geometry.y_offset = 0;
 
+  glyphs->glyphs[i].attr.is_cluster_start = 0;
+  
   glyphs->log_clusters[i] = offset;
 
   pango_font_get_glyph_extents (font, glyphs->glyphs[i].glyph, NULL, &logical_rect);


If this is correct, it needs to be done in all backends/shapers too.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a deeply religious Amish sorceror who hangs with the wrong crowd. She's a 
time-travelling psychic college professor with someone else's memories. They 
fight crime!