Re: [PATCH] Trivial GtkIconTheme string cleanup patch

[Federico Mena Quintero <federico ximian com>]

On Thu, 2004-01-22 at 14:53, Christian Neumair wrote:
> Somebody must have borked a string when doing a recent commit to gtk/
> gtkicontheme.c. Translators don't like malformatted and disrupted
> string.
> -	      g_warning (_("Could not find the icon '%s'.  The '" DEFAULT_THEME_NAME "' theme\n"
> +	      g_warning (_("Could not find the icon '%s'. The '%s' theme\n"
>  			   "was not found either, perhaps you need to install it.\n"
> -			   "You can get a copy from :\n"
> -			   "\thttp://freedesktop.org/Software/icon-theme/releases";),
> -			 icon_name);
> +			   "You can get a copy from:\n"
> +			   "\t%s"),
> +			 icon_name, DEFAULT_THEME_NAME, "http://freedesktop.org/Software/icon-theme/releases";);

This is not malformatted.  C allows concatenation of strings as such:

	char *hello_world = "hello " "world";

Note that DEFAULT_THEME_NAME is

	#define DEFAULT_THEME_NAME "hicolor"

Maybe gettext doesn't like string concatenation with a macro in the
middle?

  Federico