Re: gtkmenu.c - attachment issues ...

[Alexander Larsson <alexl redhat com>]

On Thu, 2004-01-22 at 21:52, Matthias Clasen wrote:
> Am Do, den 22.01.2004 schrieb Alexander Larsson um 15:22:
> > On Thu, 2004-01-22 at 13:52, Matthias Clasen wrote:
> > > Ouch, appears there is a simple thinko in my version of Michaels
> > > gtk_menu_do_remove(). I'm setting priv->columns to zero before the loop in
> > > order to recalculate it, yet expect to check priv->columns == 1 in order to
> > > recognize regular menus in the loop. You could try
> > > to insert 
> > > 
> > > gboolean single_column = priv->columns == 1 ? TRUE :  FALSE;
> > > 
> > > before the resetting of priv->columns, and replace the priv->columns == 1
> > > check by 
> > > 
> > > single_column
> > > 
> > > and see if that fixes it for you. 
> > 
> > I tried the attached patch, and it didn't help.
> > 
> > If you have nautilus built this is easy to test, just switch to a
> > different view (e.g. list view) and see if all separators and some other
> > items in the menus get reordered.
> 
> Alex, could you try again. I've fixed another stupidity no more than 10
> lines below the first one - a bug cluster...

That fixes it. Thanks!

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a benighted drug-addicted ex-con haunted by memories of 'Nam. She's a 
sharp-shooting nymphomaniac detective who don't take no shit from nobody. They 
fight crime!