On Wed, 2004-07-07 at 22:44, Federico Mena Quintero wrote: > GtkFileSystemModel has a bunch of delicate code to handle a multi-level > file system tree: fancy delayed destruction of nodes, blah blah. > However, these days we never use GtkFileSystemModel as anything other > than a single-level display of a file system folder; we don't have > expandable nodes any more, as we always set the max_depth to 0. > > It seems to me that we could remove all the code to handle multi-level > trees and just keep GtkFileSystemModel as simple glue between > GtkFileFolder and GtkTreeView. This would make the code a lot smaller > and simpler to the point of being almost trivial. I'd say anything that reduces the line count of GTK+ while keeping the same functionality is a win. The only thing that seems possibly tricky is that I don't think such a major change should be done on the stable branch, so there would be more divergence to deal with for bug fixes. Regards, Owen
Attachment:
signature.asc
Description: This is a digitally signed message part