Re: UNIX/WIN32 exports in 2.3.5

["J. Ali Harlow" <ali juiblex co uk>]

On 2004.03.05 15:23 Owen Taylor wrote:
> On Fri, 2004-03-05 at 09:40, J. Ali Harlow wrote:
>
> Well, for starters, anything that doesn't start with g_ pango_ / gtk_
> / gdk_ shouldn't be exported. (Not sure about glib_on_error_halt 
> without
> looking further.)

http://developer.gnome.org/doc/API/2.0/glib/glib-Warnings-and-Assertions.html#g-on-error-query

The documentation doesn't say so, but it's ignored under WIN32, so I'll
assume it should not be exported.

I suspect g_child_watch_funcs is only exported under UNIX by mistake.

That just leaves g_main_depth as missing from glib.def.

> Some other stuff shouldn't be exported; in a quick look, I see:

[snip]

Leaving the following:

Missing from win32 pango:

pango_attr_fallback_new
pango_engine_get_type
pango_engine_lang_get_type
pango_engine_shape_class_init
pango_itemize_with_base_dir
pango_layout_get_auto_dir
pango_layout_set_auto_dir
pango_script_for_lang
pango_unichar_direction

Missing from win32 pangoft2:

pango_fc_font_description_from_pattern
pango_fc_font_map_cache_clear
pango_fc_font_map_create_context
pango_fc_font_map_get_type
pango_fc_font_map_shutdown
pango_ft2_font_get_cache_glyph_data
pango_ft2_font_map_substitute_changed
pango_ft2_font_set_cache_glyph_data
pango_ft2_font_set_glyph_cache_destroy
pango_ot_buffer_add_glyph
pango_ot_buffer_clear
pango_ot_buffer_destroy
pango_ot_buffer_get_glyphs
pango_ot_buffer_new
pango_ot_buffer_output
pango_ot_buffer_set_rtl
pango_ot_info_get_gdef
pango_ot_info_get_gpos
pango_ot_info_get_gsub
pango_ot_info_get_type
pango_ot_ruleset_get_type
pango_ot_ruleset_position
pango_ot_ruleset_substitute

Erroneously including in win32 pangoft2:

pango_ot_ruleset_shape

Missing from win32 gdk_pixbuf:

gdk_pixbuf_major_version
gdk_pixbuf_micro_version
gdk_pixbuf_minor_version
gdk_pixbuf_non_anim_new
gdk_pixbuf_version

Missing from win32 gdk:

gdk_cursor_new_from_pixbuf
gdk_display
gdk_display_get_default_cursor_size
gdk_display_get_default_group
gdk_display_get_maximal_cursor_size
gdk_display_supports_cursor_alpha
gdk_display_supports_cursor_color
gdk_drawable_copy_to_image
gdk_event_send_client_message_to_all_recurse
gdk_font_get_display
gdk_net_wm_supports
gdk_pixmap_get_type
gdk_spawn_command_line_on_screen
gdk_spawn_on_screen
gdk_spawn_on_screen_with_pipes
gdk_threads_lock
gdk_threads_set_lock_functions
gdk_threads_unlock
gdk_window_get_group

Missing from win32 gtk:

(I've also removed the gtk_plug and gtk_socket functions, which I see 
are x11 specific)

gtk_accel_map_get
gtk_accel_map_get_type
gtk_bindings_activate_event
gtk_combo_box_popdown
gtk_combo_box_popup
gtk_drag_source_get_target_list
gtk_drag_source_set_target_list
gtk_draw_insertion_cursor
gtk_entry_get_alignment
gtk_entry_set_alignment
gtk_file_chooser_dialog_new_with_backend
gtk_file_chooser_get_use_preview_label
gtk_file_chooser_set_use_preview_label
gtk_file_chooser_widget_new_with_backend
gtk_file_system_create_folder
gtk_file_system_module_get_type
gtk_menu_set_monitor
gtk_radio_menu_item_new_from_widget
gtk_radio_menu_item_new_with_label_from_widget
gtk_radio_menu_item_new_with_mnemonic_from_widget
gtk_scale_get_layout
gtk_scale_get_layout_offsets
gtk_text_layout_set_keyboard_direction
gtk_toggle_action_new
gtk_tooltips_get_info_from_tip_window
gtk_ui_manager_item_type_get_type
gtk_widget_add_mnemonic_label
gtk_widget_list_mnemonic_labels
gtk_widget_remove_mnemonic_label
gtk_window_activate_key
gtk_window_propagate_key_event

> > gdk_input_motion_events
>
> This looks like some sort of GTK+-1.2 leftover in the win32 code.

Probably. It's listed in docs/reference/gdk/tmpl/gdk-unused.sgml
Should we remove this function and it's export?

> > gdk_pixmap_get_type
>
> This one is as far as I know exported

Yes. My mistake. I had assumed that the .def files were perfectly 
sorted.

Cheers,

Ali.