[PATCH] HIG violations in filechooser and filesel alerts

[Gregory Merchan <merchan phys lsu edu>]

I noticed the filechooser produces an alert with a Close button. This
is a violation of the GNOME HIG. Only non-modal control panels,
property and prefs panels are supposed to use Close; simple error
alerts are supposed to use OK.

The old file selector has the same bug.

Attached is a patch for both.

Cheers,
Greg

Index: gtk/gtkfilechooserdefault.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkfilechooserdefault.c,v
retrieving revision 1.137
diff -p -u -r1.137 gtkfilechooserdefault.c
--- gtk/gtkfilechooserdefault.c	11 Mar 2004 06:24:15 -0000	1.137
+++ gtk/gtkfilechooserdefault.c	11 Mar 2004 12:06:50 -0000
@@ -633,7 +633,7 @@ error_message_with_parent (GtkWindow  *p
   dialog = gtk_message_dialog_new (parent,
 				   GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
 				   GTK_MESSAGE_ERROR,
-				   GTK_BUTTONS_CLOSE,
+				   GTK_BUTTONS_OK,
 				   "%s",
 				   msg);
   gtk_dialog_run (GTK_DIALOG (dialog));
Index: gtk/gtkfilesel.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkfilesel.c,v
retrieving revision 1.149
diff -p -u -r1.149 gtkfilesel.c
--- gtk/gtkfilesel.c	6 Mar 2004 03:37:44 -0000	1.149
+++ gtk/gtkfilesel.c	11 Mar 2004 12:06:53 -0000
@@ -1371,7 +1371,7 @@ gtk_file_selection_fileop_error (GtkFile
   dialog = gtk_message_dialog_new (GTK_WINDOW (fs),
 				   GTK_DIALOG_DESTROY_WITH_PARENT,
 				   GTK_MESSAGE_ERROR,
-				   GTK_BUTTONS_CLOSE,
+				   GTK_BUTTONS_OK,
 				   "%s", error_message);
 
   /* yes, we free it */