Re: g_file_write()

[Matthias Clasen <mclasen redhat com>]

On Tue, 2005-03-08 at 20:49 +0100, Soeren Sandmann wrote:
> I have put up a new patch at
>  
>        http://www.daimi.au.dk/~sandmann/filewrite2.patch 
> 
> that should take care of most of the comments:
> 
> - Function is now called g_file_replace(). (I think
>   g_file_replace_contents() suggests that permissions etc. are
>   preserved).
> 
> - Documentation mentions that the write is atomic, and some of the
>   traps.
> 
> - Uses fdopen(). Since we are already using fdopen() on Unix
>   in one place, and Tor says that it works as expected on Windows I
>   don't think this makes glib any less portable than it already is.
> 
> - Test/unlink is only done on Windows and only when an initial rename
>   attempt failed.

Looks good to me. Just add "Since: 2.8" to the docs, and it should be
ready to go.

Once it is in GLib, we may want to use it e.g. in updateiconcache.c.

Matthias