Re: Trouble with inverted tree view background (arabic version) - bug correction submition

[Eric Cazeaux <cazeaux enib fr>]

Hi Behdad,


I just submited bug at bugzilla (Ref 318781).
Don't hesitate to tell me if i missed something...

Eric


Le jeudi 13 octobre 2005 à 06:17 -0400, Behdad Esfahbod a écrit :
> Hi Eric,
> 
> Thanks for the note.  Indeed it's a bug, and your solutions
> generally looks right.  Please file a bug at the bugzilla
> (http://bugzilla.gnome.org/)  You need to create an account first
> if you do not have already.  Then attach the patch to the bug,
> and also attach screenshots of a test program before and after
> the patch, and attach the test program too.  Please add me to the
> CC field using the  gnome at behdad dot org address.
> 
> This way you can be sure that the proper fix will be in the next
> version of gtk+ :).
> 
> Thanks again
> behdad
> 
> 
> 
> On Wed, 12 Oct 2005, Eric Cazeaux wrote:
> 
> > Hi,
> >
> > When i fill cell on GtkTreeView with a background color, all work fine in "normal" direction, but in inverted mode  (eg Arabic), background overlap sibling cells...
> > I think i have found the source of the problem...
> >
> > In function gtk_tree_view_column_cell_process_action of
> > gtk/gtktreeviewcolumn.c
> >
> > The variable depth is used to compute offset between background and cell
> > border (taking into account horizontal_separator).
> > I think that this calculus must be different in inverted mode (so 'rtl'
> > variable value is true).
> >
> > Well the original calculus is :
> >
> > depth = real_cell_area.x - real_background_area.x -
> > horizontal_separator/2;
> >
> > Now my modification is :
> >
> > if (rtl)
> >   {
> >     depth = real_background_area.width - real_cell_area.width -
> > horizontal_separator/2;
> >   }
> >   else
> >   {
> >     depth = real_cell_area.x - real_background_area.x -
> > horizontal_separator/2;
> >   }
> >
> >
> > And now treeview with background filled work perfectly!
> > So now, how can i submit this modification...to be took account for a
> > later release of gtk?
> >
> >
> > Eric
> >
> >
> > _______________________________________________
> > gtk-devel-list mailing list
> > gtk-devel-list gnome org
> > http://mail.gnome.org/mailman/listinfo/gtk-devel-list
> >
> >
> 
> --behdad
> http://behdad.org/
> 
> "Commandment Three says Do Not Kill, Amendment Two says Blood Will Spill"
> 	-- Dan Bern, "New American Language"