Re: Pango-1.11.99 "Just In Case" released [unstable]

[Owen Taylor <otaylor redhat com>]

On Mon, 2006-02-27 at 12:11 -0600, Federico Mena Quintero wrote:
> On Sun, 2006-02-26 at 21:47 -0500, Behdad Esfahbod wrote:
> > * Insert '?' chars instead of invalid UTF-8 sequences in
> >   pango_layout_set_text [#33195]
> 
> A long, long time ago we mande the decision to assume that
> pango_layout_set_text() gets a valid UTF-8 string.  Doing otherwise
> would kill performance.  This requirement is even documented in that
> function's docs.  Can't we add something to the docs instead, along the
> lines of "if you crash inside this function, you passed an invalid UTF-8
> sequence, doofus!".

Note also that if  you pass in a UTF-8 sequence, you don't crash
*inside* that function, you crash at some later point with an assertion
failure because Pango chars and glyphs counts are out of sync or
similar.

						Owen