Re: [PATCH] Don't multiply by -1 when assigning memory



On Wed, 2006-01-04 at 07:34 -0500, Matthias Clasen wrote:
> On Wed, 2006-01-04 at 13:18 +0100, Rodrigo Moya wrote:
> > Hi
> > 
> > Attached patch fixes a problem I just found out. Running any GTK app
> > showed this:
> > 
> > GLib-ERROR **: gmem.c:143: failed to allocate 68719477360 bytes
> > 
> > I found the culprit to be the patched function, which was multiplying by
> > -1 when n_args was 0.
> > 
> > Ok to commit to HEAD?
> 
> No, thats not the right fix. We do want to subtract one GtkBindingArg
> size from the GtkBindingSignal size there. 
> 
that's what it does for all cases, except when it is 0.

rambokid approved it on IRC, so it's committed. Let me know what fix
needs to be done and I'll provide a new patch, if there's some fix to be
done.
-- 
Rodrigo Moya <rodrigo gnome-db org>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]