Re: [patch] Print Preview

[Alexander Larsson <alexl redhat com>]

On Thu, 2006-05-11 at 21:07 -0400, John (J5) Palmieri wrote:
> Here is my patch for print preview.  I haven't created the signal yet
> but that should be a trivial change.  Right now we just work as if the
> user hit print.  The dialog is dismissed and evince (or whatever is
> configured as the gtk-print-preview-command settings property) is
> launched.  We default to "evince %f".  The dialog dismissal works like
> MacOSX works.  I'm not sure if we want to keep the print dialog around
> anymore.

Is this really what you expect? Closing the print dialog when showing
the preview seems kind of surprising to me. I'd expect it to show the
preview, and when you close that you can continue to tweak the settings.
Also, this is very visible in the API, with the print operation actually
terminating (forcing you to either forget the changes to the settings,
or save "non-final" settings). 

Btw. the way this integrates with the print loop is probably gonna be
affected by the async changes that has been discussed.

Is using the pdf printing backend really needed to do the print preview?
Isn't something similar to gtk_print_operation_set_pdf_target() good
enough?

One issue with having the print preview not terminating the print
operation is that apps will have to handle the print loop running
multiple times in one print-operation.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a benighted misogynist grifter on a search for his missing sister. She's 
a supernatural belly-dancing research scientist from beyond the grave. They 
fight crime!