Re: Wimp tab rendering patch
- From: "Dominic Lachowicz" <domlachowicz gmail com>
- To: "Arnaud Charlet" <charlet adacore com>
- Cc: Cody Russell <bratsche gnome org>, gtk-devel-list gnome org
- Subject: Re: Wimp tab rendering patch
- Date: Fri, 20 Apr 2007 07:46:09 -0400
I committed a similar patch yesterday. It was bug #403470.
Dom
On 4/20/07, Arnaud Charlet <charlet adacore com> wrote:
> Sorry, I overlooked this message until now and just found your latest
> patch. I will review this patch really soon, and if it looks okay I'll
> get it committed to svn. Thanks a lot!
BTW, did you see my message (and the follow up) on
http://bugzilla.gnome.org/show_bug.cgi?id=399253 ?
<<
Comment #9 from charlet act-europe fr (points: 11)
2007-04-19 10:31 UTC [reply]
There's still a memory leak in the case of e.g. Windows Classic style,
fixed by the following patch:
<<
--- msw_style.c.old
+++ msw_style.c
@@ -2541,6 +2548,9 @@ draw_extension (GtkStyle * style,
HDC dc;
gint32 aPosition;
+ if (real_gap_side == GTK_POS_BOTTOM)
+ g_object_unref (pixmap);
+
dc = get_window_dc(style, window, state_type, x, y, width,
height, &rect);
if (real_gap_side == GTK_POS_TOP)
>>
Could someone apply it ?
Arno
Comment #10 from Daniel Atallah (reporter, points: 8)
2007-04-19 14:29 UTC [reply]
The fix for comment #9, and an additional fix for the LEFT/RIGHT tabs is in Bug
#403470.
>>
Arno
_______________________________________________
gtk-devel-list mailing list
gtk-devel-list gnome org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list
--
Counting bodies like sheep to the rhythm of the war drums.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]