Re: SoupInputStream / trying out gio



On Wed, 2007-12-05 at 18:45 -0500, Matthias Clasen wrote:
> On Dec 5, 2007 3:28 AM, Alexander Larsson <alexl redhat com> wrote:
> >
> > On Tue, 2007-12-04 at 15:59 -0500, Morten Welinder wrote:
> > > > I added an extra check for ->write != NULL in the splice case (because
> > > > write() already did that) and commited.
> > >
> > > I would be to avoid having struct members called write.  That is a reserved
> > > symbol and if the C library decides to use a macro you will have some very
> > > interesting effects.
> >
> > Oh, yeah. Maybe we should rename it to something like _write?
> >
> > What other symbols can be macros like this? close? read?
> >
> 
> What we have done previously in cases like this is to append a _, ie
> index --> index_

Oh, I did this as close -> close_fn, which i've seen in other code.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]