missing -lm for gtk+/gdk-pixbuf/pixops/pixops.c

[Tim Janik <timj gtk org>]

hi Tor.

your recent change:

  2007-07-03  Tor Lillqvist  <tml novell com>

         * configure.in: Handle GDK_PIXBUF_EXTRA_LIBS like GDK_EXTRA_LIBS,
         i.e. clear it if enable_explicit_deps isn't on. If we build with
         --with-included-loaders and --enable-explicit-deps=no we don't
         want -ltiff -ljpeg etc in the gdk-pixbuf-2.0.pc file.

breaks the build due to missing -lm:

$ fgrep MATH_LIB * -n
configure.in:116:MATH_LIB=-lm
configure.in:121:    MATH_LIB=
configure.in:517:    MATH_LIB=
configure.in:1051:GDK_PIXBUF_EXTRA_LIBS="$STATIC_LIB_DEPS $MATH_LIB $MEDIA_LIB"

$ make
Making all in pixops
make[4]: Entering directory `/usr/src/gtk+doc/gtk+/gdk-pixbuf/pixops'
/bin/bash ../../libtool --mode=link gcc  -DG_DISABLE_DEPRECATED -g -O2 -g -Wall   -o timescale  timescale.o libpixops.la -pthread -L/usr/src/gtk+doc/installation/lib -lgobject-2.0 -lgmodule-2.0 -ldl -lgthread-2.0 -lrt -lglib-2.0 
gcc -DG_DISABLE_DEPRECATED -g -O2 -g -Wall -o timescale timescale.o -pthread  ./.libs/libpixops.a -L/usr/src/gtk+doc/installation/lib /usr/src/gtk+doc/installation/lib/libgobject-2.0.so /usr/src/gtk+doc/installation/lib/libgmodule-2.0.so -ldl /usr/src/gtk+doc/installation/lib/libgthread-2.0.so -lpthread -lrt /usr/src/gtk+doc/installation/lib/libglib-2.0.so -Wl,--rpath -Wl,/usr/src/gtk+doc/installation/lib -Wl,--rpath -Wl,/usr/src/gtk+doc/installation/lib
./.libs/libpixops.a(pixops.o): In function `bilinear_box_make_weights':
/usr/src/gtk+doc/gtk+/gdk-pixbuf/pixops/pixops.c:1529: undefined reference to `ceil'
./.libs/libpixops.a(pixops.o): In function `bilinear_magnify_make_weights':
/usr/src/gtk+doc/gtk+/gdk-pixbuf/pixops/pixops.c:1434: undefined reference to `ceil'
./.libs/libpixops.a(pixops.o): In function `tile_make_weights':
/usr/src/gtk+doc/gtk+/gdk-pixbuf/pixops/pixops.c:1380: undefined reference to `ceil'
./.libs/libpixops.a(pixops.o): In function `pixops_process':
/usr/src/gtk+doc/gtk+/gdk-pixbuf/pixops/pixops.c:1265: undefined reference to `floor'
collect2: ld returned 1 exit status
make[4]: *** [timescale] Error 1

reverting your attached patch fixes the build for pixops.c.

---
ciaoTJ

Index: configure.in
===================================================================
diff -Nup /tmp/tmp /tmp/tmp.2
--- configure.in	(revision 18360)
+++ configure.in	(revision 18361)
@@ -1053,13 +1053,6 @@ GDK_PIXBUF_EXTRA_CFLAGS= 
 GDK_PIXBUF_DEP_LIBS="`$PKG_CONFIG --libs $GDK_PIXBUF_PACKAGES` $GDK_PIXBUF_EXTRA_LIBS"
 GDK_PIXBUF_DEP_CFLAGS="`$PKG_CONFIG --cflags  gthread-2.0 $GDK_PIXBUF_PACKAGES $PNG_DEP_CFLAGS_PACKAGES` $GDK_PIXBUF_EXTRA_CFLAGS"
 
-AC_SUBST(GDK_PIXBUF_PACKAGES)
-AC_SUBST(GDK_PIXBUF_EXTRA_LIBS)
-AC_SUBST(GDK_PIXBUF_EXTRA_CFLAGS)
-AC_SUBST(GDK_PIXBUF_DEP_LIBS)
-AC_SUBST(GDK_PIXBUF_DEP_CFLAGS)
-
-
 ########################################
 # Windowing system checks
 ########################################
@@ -1530,6 +1523,16 @@ ATK_PREFIX="`$PKG_CONFIG --variable=pref
 PANGO_PREFIX="`$PKG_CONFIG --variable=prefix pango`"
 CAIRO_PREFIX="`pkg-config --variable=prefix cairo`"
 
+if test $enable_explicit_deps != yes ; then
+  GDK_PIXBUF_EXTRA_LIBS=
+fi
+
+AC_SUBST(GDK_PIXBUF_PACKAGES)
+AC_SUBST(GDK_PIXBUF_EXTRA_LIBS)
+AC_SUBST(GDK_PIXBUF_EXTRA_CFLAGS)
+AC_SUBST(GDK_PIXBUF_DEP_LIBS)
+AC_SUBST(GDK_PIXBUF_DEP_CFLAGS)
+
 AC_SUBST(GTK_PACKAGES)
 AC_SUBST(GTK_EXTRA_LIBS)
 AC_SUBST(GTK_EXTRA_CFLAGS)
Index: ChangeLog
===================================================================
diff -Nup /tmp/tmp /tmp/tmp.2
--- ChangeLog	(revision 18360)
+++ ChangeLog	(revision 18361)
@@ -1,5 +1,12 @@
 2007-07-03  Tor Lillqvist  <tml novell com>
 
+	* configure.in: Handle GDK_PIXBUF_EXTRA_LIBS like GDK_EXTRA_LIBS,
+	i.e. clear it if enable_explicit_deps isn't on. If we build with
+	--with-included-loaders and --enable-explicit-deps=no we don't
+	want -ltiff -ljpeg etc in the gdk-pixbuf-2.0.pc file.
+
+2007-07-03  Tor Lillqvist  <tml novell com>
+
 	* gdk/win32/gdkkeys-win32.c (gdk_keymap_have_bidi_layouts):
 	Implement. Just return FALSE for now. What should this function
 	actually do? Does keyboards layouts being "in use" mean that such