Cannot use arrow keys to navigate the popup from gtk combobox on win32 #471655



Hi,

I filed this enhancement request last week, and since then I have taken a look at the source and come up with a patch. Unfortunately I have no idea on how to compile gtk on windows despite my best efforts. I will post my patch here in the hope that someone who can sucessfully compile gtk can spare a few minutes to test it.

It should be inserted at line 3699 which is the gtk_combo_box_list_key_press function of gtkcombobox.c. (Either 2.10.13 or 2.10.14)



if (event->keyval == GDK_Down || event->keyval == GDK_KP_Down || event->keyval == GDK_Up || event->keyval == GDK_KP_Up)
{
if (gtk_tree_row_reference_valid (combo_box->priv->active_row))
{
 GtkTreePath *path = NULL;
 path = gtk_tree_row_reference_get_path (combo_box->priv->active_row);

 if (path)
 {
  if (event->keyval == GDK_Down || event->keyval == GDK_KP_Down)
  {
   gtk_tree_path_next(path);
  }
  if (event->keyval == GDK_Up || event->keyval == GDK_KP_Up)
  {
   gtk_tree_path_prev(path);
  }
  gtk_tree_view_set_cursor (GTK_TREE_VIEW (combo_box->priv->tree_view),
    path, NULL, FALSE);
  gtk_tree_path_free (path);
 }
}
}


thanks,
Neil



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]