Re: GtkFileChooserDialog: something funny?

[Michael Natterer <mitch gimp org>]

On Fri, 2008-09-26 at 14:29 -0400, Allin Cottrell wrote:
> On Fri, 26 Sep 2008, Tor Lillqvist wrote:
> 
> > > Any ideas on what's going on?
> > 
> > http://bugzilla.gnome.org/show_bug.cgi?id=553135#c8 ?
> 
> On closer inspection, I see that Michael Natterer's patch is 
> already in gtk 2.14.3, and does not solve the problem I mentioned, 
> namely

No that patch is not in 2.14.3 unfortunately.

> GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT 
> (object)' failed
> 
> on calling gtk_widget_destroy() on a GtkFileChooserDialog.
> I guess this patch was incomplete or broken in its application to
> 2.14.3.  Line 937 in gtkfilechooserdefault.c, namely
> 
>   g_object_unref (impl->file_system);
> 
> needs to be deleted.

That's exactly what the patch does.

ciao,
--mitch