Re: GtkScrollbar marker API discussion



Hello there,
I have updated the patch, it now compiles against master and it
contains the theming API hints that thos suggested:
https://bugzilla.gnome.org/show_bug.cgi?id=623712

I think the patch is pretty much ready, I have tested it with
different engines, some engines will have to do some work to prettify
the result, but other than that I think it's there.

It'll be really nice if someone can review it :-)

2010/7/16 Alberto Ruiz <aruiz gnome org>:
> 2010/7/15 Thomas Wood <thos gnome org>:
>> On Thu, 2010-07-15 at 23:40 +0100, Alberto Ruiz wrote:
>>> Hey guys,
>>> I've finally come up with a patch to implement this:
>>> https://bugzilla.gnome.org/show_bug.cgi?id=623712
>>>
>>> The patch basically calls range's expose from scrollbar, and then
>>> paint the markers on top, once that's done, the slider is painted
>>> again on top. If there's anyone with the Nimbus theme or other theme
>>> with non sqared sliders, please let me know how it behaves.
>>
>> Actually, passing an appropriate detail string would be enough to let
>> engines know that they are painting a "mark". That would allow theme
>> authors to choose whether to special case it or not.
>>
>> Also, maybe gtk_paint_flat_box() is more appropriate here?
>
> That's a good idea actually, will update the patch during the weekend :-)
>
>> Regards,
>>
>> Thomas
>>
>>
>
>
>
> --
> Un saludo,
> Alberto Ruiz
>



-- 
Un saludo,
Alberto Ruiz


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]