Re: Make GtkPlug and GtkSocket X11-specific - unfinished

[John Ralls <jralls ceridwen us>]

On Jan 30, 2011, at 2:39 PM, Hans Breuer wrote:

> Current master - when build on windoze - gives:
> 
> gtkstatusicon.c
> gtktrayicon.h(40) : error C2061: syntax error : identifier 'GtkPlug'
> gtktrayicon.h(43) : error C2059: syntax error : '}'
> gtktrayicon.h(47) : error C2061: syntax error : identifier 'GtkPlugClass'
> gtktrayicon.h(54) : error C2059: syntax error : '}'
> 
> due to:
> 
> Revision: 3860af516c0119d93ccfa5c138f32e20e490c2a9
> Author: Benjamin Otte
> Date: 28.01.2011 10:47:34
> Message:
> plug/socket: Make GtkPlug and GtkSocket X11-specific
> 
> (or better the wrong inclusion of gtktrayicon.h in gtkstatusicon.c)
> 
> 
> But there are also unconditional uses of GTK_IS_PLUG in
> 
> gtkwidget.c(gtk_widget_set_parent_window)
> gtkwindow.c(gtk_window_show)
> 
> Should these just get the extra
> #ifdef GDK_WINDOWING_X11
> or is there a better way to fix these?
> 

This is also the case in the quartz backend.

Regards,
John Ralls