Re: libegg: Removing old directories



On Tue, 2011-03-22 at 13:03 +1300, John Stowers wrote:
> On Mon, 2011-03-21 at 10:51 +0100, Murray Cumming wrote:
> > On Sun, 2011-03-20 at 20:03 -0400, Matthias Clasen wrote:
> > > On Fri, Mar 18, 2011 at 6:42 PM, Murray Cumming <murrayc murrayc com> wrote:
> > > > libegg has lots of directories that have just a README saying how the
> > > > code has successfully moved into GTK+. But that's mostly old news now.
> > > > If there's no objection then I'll remove the directories so it's easier
> > > > to see at a glance what's still interesting.
> > > >
> > > 
> > > Sounds fine to me.
> 
> While we are talking about egg.
> 
> I recently copied eggaccelerators.{c,h} and tomboykeybinder-ish for
> global keybinding in a project.
> 
> I wonder if these are worth having in egg. eggaccelerators.{c,h} gets
> copied all over the place but the most up-to-date copy lives in
> gnome-control-center currently [1].
> 
> tomboykeybinder too exists in many different forms, copied into at least
> tomboy [2], guake terminal and kupfer (which also ships bindings for
> it).
> 
> Would anyone be interested in these in egg [3]?

In the future, we'll want to be able to capture keys from one place,
either gnome-settings-daemon or gnome-shell, to avoid clashes, work
properly in the overview mode for some, etc.

If all those applications are supposed to be integrated in GNOME, then
it would be better to extend gnome-settings-daemon to support that (see
https://bugzilla.gnome.org/show_bug.cgi?id=525428 ) rather than having
those copy-pasting the code in each module.

Furthermore, libegg is supposed to be a stop-gap for API to be tested
before it goes into GTK+, not a random dumping ground, and I really
don't think we want to see this code going into GTK+.

Cheers

> [1]
> http://git.gnome.org/browse/gnome-control-center/tree/panels/common/eggaccelerators.h
> [2] http://git.gnome.org/browse/tomboy/tree/libtomboy/tomboykeybinder.h
> [3] I might GObject-ify tomboykeybinder first, so it is introspectable
> 
> 
> _______________________________________________
> gtk-devel-list mailing list
> gtk-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gtk-devel-list




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]