ATK test is failing

[John Emmas <johne53 tiscali co uk>]

Hi there,

This morning I built libatk v2.7.91 (Windows / MSVC) from the latest git 
code (downloaded about 4 days ago).  Having built the library I decided 
to build the two test modules.  Unfortunately, testrelation.c gave me 
this error at run-time:-

      Relation test module loaded
      Relation tests succeeded
      Unexpected name for ATK_ROLE_PAGE_TAB page tab
      Role tests failed

Here's the relevant test, from line 174 of testrelation.c

  const gchar *name;
  name = atk_role_get_name (ATK_ROLE_PAGE_TAB);
  g_return_val_if_fail (name, FALSE);
  if (strcmp (name, "page-tab") != 0)
    {
      g_print ("Unexpected name for ATK_ROLE_PAGE_TAB %s\n", name);
      return FALSE;
    }

The test retrieves an entry from a table called "roles" (defined in 
atk/atkobject.c).  It tests to check that the retrieved entry has the 
name "page-tab" (note the hyphen).  However, here's what the 'roles' 
table actually looks like at line 179 of atk/atkobject.c:-

  static const char roles[] =

    // the preceding table entries

    "page tab\0"

    // the remaining table entries
  };

Note that the actual entry has no hyphen.  I'm assuming that the test 
and the table entry can't both be right.  Which should I change?  The 
table entry or the test?  Thanks.

John