Re: Memory tracking in GJS

[Cosimo Cecchi <cosimoc gnome org>]

On Tue, Feb 25, 2014 at 11:08 AM, Bastien Nocera <hadess hadess net> wrote:

On Mon, 2014-02-24 at 13:56 -0800, Cosimo Cecchi wrote:
> Thanks all for your inputs; I now posted a first iteration of a patch
> that implements the suggestions of this thread here
>
>
> https://bugzilla.gnome.org/show_bug.cgi?id=725099

This is pretty similar to Giovanni's patch, no?

https://bugzilla.gnome.org/show_bug.cgi?id=724797

Only partly; the last patch of Giovanni's just calls JS_MaybeGC(), which won't look at the memory allocation as reported by the kernel, whereas my patch will schedule a call to gjs_maybe_gc(), which also has the logic Colin linked to before. I also schedule that from a bunch more places than Giovanni's patch did.

Cheers,

Cosimo