Re: MSVC linker errors (gdk-pixbuf-buffer-queue.c)

[Benjamin Otte <otte gnome org>]

Hey,

The intention is indeed to only link gdk-pixbuf-buffer-queue.c into the tga loader, not into the main libgdkpixbuf.
GdkPixbufBufferQueue is only used by the TGA loader (so far) and as it's utility code for the loaders, it should not be public API.

Benjamin

On Mon, Oct 19, 2015 at 8:10 AM, Ignacio Casal Quinteiro <nacho resa gmail com> wrote:

Hey,

I am adding Benjamin to this discussion since it was him the one adding the new stuff to gdk-pixbuf

Cheers.

On Mon, Oct 19, 2015 at 8:08 AM, Fan, Chun-wei (范君維) <fanc999 yahoo com tw> wrote:

Hi John,

Are you building the loader modules as individual DLLs or are you buiding the loader modules right into the main GDK-Pixbuf DLL?  It seems that you are doing the former (this is unlike the MSVC 2008+ projects, by the way, where all the included loaders are built into the main GDK-Pixbuf DLL).

>From the autotools Makefiles, if I was right about how you build the loaders, you need to include the new source (gdk-pixbuf-buffer-queue.c) to the project where you build the DLL for the TGA loader, *not* the project for the main GDK-Pixbuf DLL. (Thus, I don't think for now it is the intention to export those symbols, so we don't update gdk-pixbuf.symbols at this point).

It seems to me that the autotools files need to be updated where |the line libstatic_pixbufloader_tga_la_SOURCES =||io-tga.c||||needs to become ||libstatic_pixbufloader_tga_la_SOURCES =||io-tga.c||||||gdk-pixbuf-buffer-queue.c|||.

Hope this helps.  With blessings.

_______________________________________________
gtk-devel-list mailing list
gtk-devel-list gnome org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

--

Ignacio Casal Quinteiro