small bug in gdkwindow found

[Michael Lausch <mla gams co at>]

While hacking gnome i discovered the following:

------- Forwarded Message

To: jirka@5z.com
cc: gnome-list@gnome.org
Subject: swallow bug found
Date: Mon, 13 Jul 1998 16:59:22 +0200
From: Michael Lausch <mla@loki.gams.co.at>


The problem with swallowing non-gtk windows is caused by the
gdk_window_reparent function.  In this function old_parent_private is
NULL, because the foreign window has no gdk parent.

The following patch resolves the problem, swallowing of xconsole works 
again.

Index: gdkwindow.c
===================================================================
RCS file: /cvs/gnome/gtk+/gdk/gdkwindow.c,v
retrieving revision 1.50
diff -u -r1.50 gdkwindow.c
- --- gdkwindow.c 1998/07/04 15:30:01     1.50
+++ gdkwindow.c 1998/07/13 14:58:47
@@ -853,7 +853,8 @@
                     parent_private->xwindow,
                     x, y);
 
- -  old_parent_private->children = g_list_remove (old_parent_private->children, window);
+  if (old_parent_private)
+    old_parent_private->children = g_list_remove (old_parent_private->children, window);
   parent_private->children = g_list_prepend (parent_private->children, window);
   
 }

------- End of Forwarded Message