gtk2-perl / GLib-GObject-CRITICAL from GSignal.c

[Guillaume Cottenceau <gc mandrakesoft com>]

When running test-pixbuf-drawing.pl I get the following log
message on each expose_event:

GLib-GObject-CRITICAL **: file gboxed.c: line 425 (g_value_get_boxed): assertion `G_VALUE_HOLDS_BOXED 
(value)' failed


I tracked it down to the following patch:

--- Gtk2/src/GSignal.c  31 Oct 2002 15:51:58 -0000      1.18
+++ Gtk2/src/GSignal.c  5 Nov 2002 11:47:22 -0000
@@ -69,7 +69,7 @@
        if (n_param_values > 1) {
            if (strstr(pc->name, "event")) {
                event = gdkperl_event_make(g_value_get_boxed(param_values + 1));
-           }
+           } else
            if (strstr(pc->name, "selection_received")) {
                event = gtk2_perl_new_object_from_pointer(g_value_get_boxed(param_values + 1),
                                                          "Gtk2::SelectionData");



While looking at that code, what would you think of replacing:

            if (strstr(pc->name, "selection_received")) {

by:

            if (!strcmp(pc->name, "selection_received")) {



I haven't commited any of the above stuff, since I'm not sure of
these issues. Please commit by yourself the fix(es) you estimate
better.


-- 
Guillaume Cottenceau - http://people.mandrakesoft.com/~gc/