Re: [PATCH] Re: g_filename_display_name()

[Torsten Schoenfeld <kaffeetisch gmx de>]

On Sun, 2005-11-13 at 13:05 -0500, muppet wrote:

> The attached patch adds Glib::filename_display_name() and  
> Glib::filename_display_basename() as exportable functions in HEAD.   
> There is no fallback implementation, so their presence is dependent  
> upon the bindings being built against glib 2.6.0.   I'm not very fond  
> of this, but unless somebody has ideas about how to make a fallback  
> that will work without significant code duplication, i'm out of ideas.
>
> > Thoughts?
>
> Same question.  Good idea?  Bad idea?

The patch looks good to me.  Just a minor typo:

+This function is croak() if the conversion cannot be made, e.g., because the
+utf-8 is invalid.

I think you meant "will croak()".

-- 
Bye,
-Torsten