Re: Can't add new GTK 2.16 methods to GtkStyle



On Wed, Jan 28, 2009 at 12:11 AM, Kevin Ryde <user42 zip com au> wrote:
Torsten Schoenfeld <kaffeetisch gmx de> writes:

The other method, Gtk2::Style::get_property(), also clashes with
Glib::Object. The question is whether this is acceptable in the same
way as it is acceptable for Gtk2::TreeModel::get(),
...

I think it would make sense to let Gtk2::Style::get()
and get_property() be the same method

Actually, letting get_property shadow the GObject method is a bit unlike
TreeModel.  With the treemodels the get() varies but you can you can
confidently use get_property() for the object properties in whatever
generic code might operate on Glib::Object descendants.

How about leaving get_property as the GObject property accessor and give
the style accessor another name?

But which name? This has to be picked with care because a subsequent
release of GTK could introduce new methods. I was thinking of using
something like get_style_property. This name seems unique enough,
after all what are the odds of seeing gtk_style_get_style_property
land in GTK?


If you don't mind I will wait until we have reached a consensus until
a submit a next patch for this last module.

-- 
Emmanuel Rodriguez



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]