Re: Can't locate object method "add_actions"...

[Dave M <dave nerd gmail com>]

Hi again (and thanks for your patience!),
> > I think this has all been corrected now.
>
>
> Yep, mostly. ÂI still see some stray tabs, though. ÂThey jump out if your
> tab width is different from 4. Âs/\t/ Â Â/g should do the trick.
OK, this time I did a regex search for \t to ensure they're gone. :)
> OK. ÂBut the translate_string calls are now done only if the strings
> evaluate to true. ÂI think it is better to check only whether they are
> defined.
Good catch - fixed to check for defined-ness instead of truth-iness.
> OK. ÂRelatedly, in your new $process anon-subs, you have:
>
> Â Âmy (@properties) = @_;
> Â Âmy ($name, $stock_id, $label, $accelerator, $tooltip, $callback);
> Â Âfor my $p (@properties) {
> Â Â...
>
> This is confusing because they are only passed one entry at a time. Better
> use
>
> Â Âmy ($p) = @_;
> Â Âmy ($name, $stock_id, $label, $accelerator, $tooltip, $callback);
> Â Â...
Done.
> > > > â The example program is very good to have, but it would also be good to
> > > > have unit tests for the three overrides.
> >
> > I updated the original test, but not by much. ÂI didn't see the point
> > in changing anything because the specs don't seem to differ from 2 ->
> > 3. Again, I have limited experience in writing tests, so I might need
> > some help with that.
>
>
> The test looks fine.
>
>
> > I've included a diff, an updated test file, and the uimanager.pl as
> > well. ÂI'm open to additional feedback.
>
>
> One final request: please put your additions to Gtk3.pm into their correct
> position according to the sorting used. ÂThat is, the
> 'Gtk3::ActionGroup::list_actions' should move to the top of
> @_GTK_FLATTEN_ARRAY_REF_RETURN_FOR, and the subs should move above the sub
> Gtk3::Builder::add_objects_from_file.
Done.

The attached tarball contains a diff from Gtk3 (v6), and a Gtk3 (v6)
with the changes.
> > Also, and semi-offtopic, I have begun creating updated versions of
> > gtk2-demo examples here:
> > https://github.com/dave-theunsub/gtk3-perl-demos.git
>
>
> Great! ÂOnce you feel happy with the code, we can also merge this into Gtk3.
Maybe I'll start another thread on this.  Right now, they're written
to run stand-alone and to require little modification to be plugged
into a "main.pl" as was before. We can either have $someone try to
update main.pl, or these can be lumped in an "examples" directory or
something.  I'd like to know how folks would like to proceed.
> _______________________________________________

Thanks,
Dave M

Attachment: add_actions3.tar.gz
Description: GNU Zip compressed data